Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libaec: init at 1.0.4; zopfli: include all headers #87205

Merged
merged 2 commits into from May 9, 2020

Conversation

tbenst
Copy link
Contributor

@tbenst tbenst commented May 7, 2020

Motivation for this change

Add/fix imagecodecs dependencies

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bobvanderlinden
Copy link
Member

I have very limited connectivity at the moment, so I won't be able to test this in the next few weeks.

adisbladis pushed a commit to tbenst/poetry2nix that referenced this pull request May 8, 2020
@adisbladis
Copy link
Member

@GrahamcOfBorg build libaec zopfli

@adisbladis adisbladis merged commit a34175b into NixOS:master May 9, 2020
adisbladis pushed a commit to tbenst/poetry2nix that referenced this pull request May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants