Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libiberty: use pname #87164

Merged
merged 1 commit into from May 8, 2020
Merged

libiberty: use pname #87164

merged 1 commit into from May 8, 2020

Conversation

sheenobu
Copy link
Contributor

@sheenobu sheenobu commented May 7, 2020

Motivation for this change

defining pname attribute

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from abbradar and Ericson2314 May 7, 2020 06:31
@jonringer
Copy link
Contributor

since this change causes over 500 rebuilds, do you mind targeting the staging branch

git rebase --onto=staging HEAD~1
git push .. ... --force

then change the base branch in the github PR from master -> staging

See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch for more details on staging branch

@Ericson2314 Ericson2314 changed the base branch from master to staging May 7, 2020 18:57
@Ericson2314 Ericson2314 changed the base branch from staging to master May 7, 2020 18:57
@Ericson2314
Copy link
Member

Please rebase, looks good otherwise.

@Ericson2314 Ericson2314 closed this May 7, 2020
@Ericson2314 Ericson2314 reopened this May 7, 2020
@FRidh FRidh changed the base branch from master to staging May 8, 2020 04:50
@FRidh FRidh added this to WIP in Staging via automation May 8, 2020
@FRidh FRidh moved this from WIP to Ready in Staging May 8, 2020
@FRidh FRidh merged commit ea56589 into NixOS:staging May 8, 2020
Staging automation moved this from Ready to Done May 8, 2020
@sheenobu
Copy link
Contributor Author

missed the messages, thanks for moving to staging and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sheenobu @jonringer @Ericson2314 @FRidh