Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcher: 1.5.60 -> 1.5.86 #86228

Merged
merged 1 commit into from May 10, 2020
Merged

etcher: 1.5.60 -> 1.5.86 #86228

merged 1 commit into from May 10, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 28, 2020 •
edited

Motivation for this change

Version update.

This also bumps dependency from very old Electron 3 to relatively new Electron 7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request Apr 28, 2020
Closed
@ofborg ofborg bot requested a review from Shou April 28, 2020 16:54
@prusnak prusnak mentioned this pull request Apr 28, 2020
Merged
10 tasks
@prusnak
Copy link
Member Author

prusnak commented Apr 28, 2020

@GrahamcOfBorg build etcher

Shou
Shou reviewed Apr 28, 2020
View reviewed changes
pkgs/tools/misc/etcher/default.nix
# We'll use our Nixpkgs electron_3 instead
rm $out/opt/balenaEtcher/balena-etcher-electron
substituteInPlace $out/share/applications/balena-etcher-electron.desktop \
--replace 'Exec=/opt/balenaEtcher/balena-etcher-electron' 'Exec=${pname}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't an absolute path, i.e. $out/bin/etcher safer here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but the vast majority of desktop files on my system have only relative names in them:

find -name "*.desktop" -type f -exec grep Exec {} \;

Not sure what is the policy in nixpkgs.

@prusnak prusnak changed the title etcher: 1.5.60 -> 1.5.82 etcher: 1.5.60 -> 1.5.83 May 2, 2020
@prusnak prusnak mentioned this pull request May 2, 2020
Closed
@ofborg ofborg bot requested a review from Shou May 2, 2020 09:13
Shou
Shou approved these changes May 2, 2020
View reviewed changes
Copy link
Contributor

@Shou Shou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prusnak prusnak changed the title etcher: 1.5.60 -> 1.5.83 etcher: 1.5.60 -> 1.5.86 May 6, 2020
@prusnak prusnak mentioned this pull request May 6, 2020
Closed
@ofborg ofborg bot requested a review from Shou May 6, 2020 19:56
@mmahut mmahut merged commit 5975bbb into NixOS:master May 10, 2020
@prusnak prusnak deleted the etcher branch May 10, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shou Shou Awaiting requested review from Shou

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @Shou @mmahut