known_hosts: Don't update a key to an empty IP address #1332
Conversation
Remove keys that have an empty IP address instead of trying to re-add them during the update phase. Should resolve error seen in nix-community/nixops-vbox#3 (comment)
|
I tested this on nixops-vbox with |
| @@ -66,4 +66,5 @@ def update(prev_address: str, new_address: str, public_host_key: str) -> None: | |||
| # FIXME: this rewrites known_hosts twice. | |||
| if prev_address != new_address: | |||
| remove(prev_address, public_host_key) | |||
| add(new_address, public_host_key) | |||
| if new_address is not None: | |||
There was a problem hiding this comment.
shouldn't remove also be conditioned to this check?
There was a problem hiding this comment.
Possibly. I don't know a good way to test changes do this code, so I was not comfortable going beyond a break-fix.
My guess is that none of these were meant to be called with empty IP addresses, and that the Virtualbox plugin is broken somewhere.
|
I think the better option is to delete the |
|
Good to close. 👍 |
Remove keys that have an empty IP address instead of trying to re-add
them during the update phase.
Should resolve error seen in
nix-community/nixops-vbox#3 (comment)