Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openexr: Switch to cmake-based build #86241

Merged
merged 1 commit into from Apr 29, 2020
Merged

openexr: Switch to cmake-based build #86241

merged 1 commit into from Apr 29, 2020

Conversation

glittershark
Copy link
Member

@glittershark glittershark commented Apr 28, 2020 •
edited by flokli

It appears that the autotools based build isn't supported on Darwin.
This is an attempt to just use the stdenv-builtin cmake build
everywhere.

Motivation for this change

Fixes #86134 - openexr breaks on darwin due to unsupported autotools based build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @flokli @eraserhd

@lovesegfault
Copy link
Member

Can ilmbase also be moved over to cmake or only openexr?

@glittershark
Copy link
Member Author

I haven't tried it or looked into it, but I would assume so

eraserhd
eraserhd approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@eraserhd eraserhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works on my machine, also.

@flokli
Copy link
Contributor

flokli commented Apr 28, 2020

I pushed the ilmbase move to cmake into here as well :-)

@flokli
Copy link
Contributor

flokli commented Apr 28, 2020

@GrahamcOfBorg build ilmbase

@worldofpeace
Copy link
Contributor

This needs to target staging because of the rebuilds.

@glittershark glittershark changed the base branch from master to staging April 28, 2020 21:53
@glittershark
Copy link
Member Author

@worldofpeace changed the base

@glittershark
openexr,ilmbase: Switch to cmake-based build
f509255 
It appears that the autotools based build isn't supported on Darwin.
Just use the stdenv-builtin cmake build everywhere, as it works just
fine and is simpler.
worldofpeace
worldofpeace approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for eval

@worldofpeace worldofpeace merged commit 7679b8e into NixOS:staging Apr 29, 2020
@veprbl veprbl mentioned this pull request Apr 29, 2020
Merged
10 tasks
This was referenced Aug 10, 2020
Merged
Closed
@glittershark glittershark deleted the openexr-cmake branch August 10, 2020 18:24
@jtojnar jtojnar mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eraserhd eraserhd eraserhd approved these changes

@flokli flokli flokli approved these changes

@lovesegfault lovesegfault lovesegfault approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openexr fails to build on Mac OS X since e5e31593cebf0322fff2badcb8f85eb2cd40da74
5 participants
@glittershark @lovesegfault @flokli @worldofpeace @eraserhd