nixos/znc: add proxychains support, maintainers, password tip #86226
Conversation
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
Still important. Dependent PR merged, this one rebased. |
|
cc @infinisil |
| @@ -255,7 +270,12 @@ in | |||
| User = cfg.user; | |||
| Group = cfg.group; | |||
| Restart = "always"; | |||
| ExecStart = "${pkgs.znc}/bin/znc --foreground --datadir ${cfg.dataDir} ${escapeShellArgs cfg.extraFlags}"; | |||
| ExecStart = '' | |||
| ${optionalString cfg.proxychains.enable "${pkgs.proxychains}/bin/proxychains4 "}${pkgs.znc}/bin/znc \ | |||
There was a problem hiding this comment.
I don't really like how non-generic this is. Feels like this should be configurable independently somehow, though I don't really know how that would look
There was a problem hiding this comment.
If we have N different proxy services and M different services, using this pattern means that we need N*M NixOS options to support all combinations
There was a problem hiding this comment.
It's certainly achievable with overlay or setting a wrapper via systemd.services... but this makes it easy to just enable the support.
I'm not concerned about N*M explosion since this is the only commonly used proxy(/wrapper) with ZNC.
Tangentially related this also needs setting up at least
programs.proxychains.enable = true;
services.tor.client.enable = true;If you prefer I can drop this from the PR and carry that downstream.
There was a problem hiding this comment.
If we have N different proxy services and M different services, using this pattern means that we need N*M NixOS options to support all combinations
I support @infinisil's opinion. This PR is good overall and should be merged IMO.
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Motivation for this change
Privacy. Weakly depends on #86225.
Things done
proxychainssupportsandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)