Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentencepiece: 0.1.85 -> 0.1.86 #86186

Merged
merged 1 commit into from May 1, 2020
Merged

sentencepiece: 0.1.85 -> 0.1.86 #86186

merged 1 commit into from May 1, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog:

https://github.com/google/sentencepiece/releases/tag/v0.1.86

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
Copy link
Contributor Author

Ping @pashashocky

@pashashocky
Copy link
Contributor

@danieldk yeah, fine with me - thanks for fyi

@danieldk danieldk requested a review from jonringer April 30, 2020 08:41
@FRidh FRidh merged commit 2cde8af into NixOS:master May 1, 2020
@danieldk danieldk deleted the sentencepiece-0.1.86 branch July 6, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @pashashocky @FRidh