Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome: document packaging icon themes #86198

Merged
merged 2 commits into from May 7, 2020
Merged

gnome: document packaging icon themes #86198

merged 2 commits into from May 7, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 28, 2020

Motivation for this change

Document some details of packaging icon themes.

See also #85229 (comment).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Apr 28, 2020
@romildo @jtojnar
Apply suggestions from code review
6449a4e 
Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
@romildo
Copy link
Contributor Author

romildo commented May 3, 2020

Can this be merged?

@romildo romildo merged commit f528989 into NixOS:master May 7, 2020
@romildo romildo deleted the doc.icon-themes branch May 7, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @jtojnar @worldofpeace