Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: graalvm 19.2.1 -> 20.0.0 (plus some refactoring) #86244

Closed
wants to merge 8 commits into from
Closed

WIP: graalvm 19.2.1 -> 20.0.0 (plus some refactoring) #86244

wants to merge 8 commits into from
+2,068 −981

Conversation

hlolli
Copy link
Member

@hlolli hlolli commented Apr 28, 2020

Motivation for this change

Requested update and refactor #83080

Rebased on this pending PR #85902

Things done

Still WIP, feel free to give feedback. As of this writing I've only compiled the sdk (core) of graalvm for java8. Java11 support should be much easier. As well as splitting some of the modules (FastR/graal-js/GraalRuby etc) as this is too much for 1 person to maintain.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@hlolli hlolli requested a review from volth April 28, 2020 18:51
@hlolli hlolli mentioned this pull request May 15, 2020
Closed
9 tasks
kennyballou added a commit to kennyballou/cfg.nix that referenced this pull request Jun 26, 2020
@kennyballou
jvm: disable clj-kondo
a7dfbeb 
This package brings in graalvm, which is currently failing to compile on
all of my nixos machines.

Will be watching various issues and PR's until for resolution.

- NixOS/nixpkgs#83080

- NixOS/nixpkgs#86244

Signed-off-by: Kenny Ballou <kballou@devnulllabs.io>
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@ryantm ryantm marked this pull request as draft October 23, 2020 03:01
@ericdallo
Copy link
Member

I think we should close this PR, it was already updated

@taku0
Copy link
Contributor

taku0 commented Jan 31, 2021

graalvm8, not graalvm8-ce or graalvm8-ee, is not updated. graalvm8-ce and graalvm8-ee are binary packages while graalvm8 builds from the source.

@hlolli hlolli closed this Feb 3, 2021
@hlolli
Copy link
Member Author

hlolli commented Feb 3, 2021

good points here. I'm keeping the branch. There was a problem with the embedded llvm compiler in the prebuilt sources. If that isn't resolved in the near future, I will continue this work. I'm still waiting for the java PR to be merged #85902 (I see now that it needs rebase), but without the static java, building graalvm from sources wont work. Must admit that in the end, it was bit demotivating that it took so much time for reviews and I had put a lot of hours in this (which is why I'm bit burnt from the graalvm from sources and happy to see the prebuilts working mostly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hlolli @ericdallo @taku0 @ryantm