Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trilium: 0.40.7 -> 0.42.1 #86192

Merged
merged 2 commits into from May 7, 2020
Merged

trilium: 0.40.7 -> 0.42.1 #86192

merged 2 commits into from May 7, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Apr 28, 2020

Motivation for this change

We currently have two package names for the trilium desktop app, trilium and trilium-desktop, which feels like a sensible distinction as the server package trilium-server also exists.
With this change, we deprecate the original trilium package in favor of the more explicit naming scheme.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Apr 28, 2020

@GrahamcOfBorg build trilium-desktop
@GrahamcOfBorg build trilium-server
@GrahamcOfBorg test trilium-server

cole-h
cole-h requested changes Apr 28, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the the deprecation and update should be done in two separate commits. trilium: deprecate for trilium-desktop and trilium-desktop: 0.40.7 -> 0.41.6 maybe?

EDIT: As noted below, since both packages are updated in tandem, trilium: 0.40.7 -> 0.41.6 is the correct commit message.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@kampka kampka force-pushed the trilium branch 2 times, most recently from 0023ad3 to 86cf1f9 Compare April 29, 2020 07:45
@kampka
Copy link
Contributor Author

kampka commented Apr 29, 2020

I think the the deprecation and update should be done in two separate commits. trilium: deprecate for trilium-desktop and trilium-desktop: 0.40.7 -> 0.41.6 maybe?

I split the commits. As for the commit message: trilium is currently updated as one (server and desktop) as they are built from the same source release. I'd therefore opt to keep the generic trilium commit message name.

@ofborg ofborg bot requested a review from dtzWill April 29, 2020 07:56
cole-h
cole-h reviewed Apr 29, 2020
View reviewed changes
pkgs/top-level/aliases.nix Outdated Show resolved Hide resolved
cole-h
cole-h approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, builds fine, runs fine.

[6 built, 4 copied (0.7 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/86192
2 packages built:
trilium-desktop trilium-server

@kampka kampka changed the title trilium: 0.40.7 -> 0.41.6 trilium: 0.40.7 -> 0.42.1 May 7, 2020
@kampka kampka requested a review from cole-h May 7, 2020 08:24
@kampka
Copy link
Contributor Author

kampka commented May 7, 2020

@GrahamcOfBorg build trilium-desktop
@GrahamcOfBorg build trilium-server
@GrahamcOfBorg test trilium-server

@Mic92
Copy link
Member

Mic92 commented May 7, 2020

Result of nixpkgs-review pr 86192 1

2 packages built:
- trilium-desktop
- trilium-server

@Mic92 Mic92 merged commit 8dba666 into NixOS:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@cole-h cole-h Awaiting requested review from cole-h

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kampka @Mic92 @cole-h