Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-studio: 25.0.3 -> 25.0.8, use addOpenGLRunpath #86214

Merged
merged 2 commits into from May 17, 2020
Merged

obs-studio: 25.0.3 -> 25.0.8, use addOpenGLRunpath #86214

merged 2 commits into from May 17, 2020

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

OBS was outdated and didn't make use of hardware-accelerated encoders like nvenc (Nvidia).

Things done

Updated to the latest version, added support for nvenc by configuring the addOpenGLRunpath fixup.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elohmeier elohmeier requested review from MP2E and jb55 April 28, 2020 14:11
@elohmeier
Copy link
Contributor Author

Restored original formatting to ease reviewing.

@elohmeier
Copy link
Contributor Author

@flokli could you take a look at this PR? It's similar to the ffmpeg PR you've reviewed.

@flokli flokli merged commit 0878903 into NixOS:master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@MP2E MP2E Awaiting requested review from MP2E

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elohmeier @flokli