-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cri-o: update module configuration #86290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @NixOS/podman
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
@@ -61,9 +61,9 @@ in | |||
network_dir = "/etc/cni/net.d/" | |||
|
|||
[crio.runtime] | |||
conmon = "${pkgs.conmon}/bin/conmon" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saschagrunert Could you readd the conmon
path please, it's needed for #86637?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 👍
- Update the default pause image - Set the cgroup manager to systemd - Enable `manage_ns_lifecycle` instead of the deprecated `manage_network_ns_lifecycle` option Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@adisbladis Could you merge this please? |
@adisbladis Ping |
Motivation for this change
manage_ns_lifecycle
instead of the deprecatedmanage_network_ns_lifecycle
optionThings done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)