Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnumake: 4.2.1 -> 4.3 #86293

Merged
merged 1 commit into from Jul 2, 2020
Merged

gnumake: 4.2.1 -> 4.3 #86293

merged 1 commit into from Jul 2, 2020

Conversation

chkno
Copy link
Member

@chkno chkno commented Apr 29, 2020 •
edited

Motivation for this change

A new version of gnumake is available. Changelog

Things done

This also cleans up some cruft about tracking multiple versions of make. The last time a package needed a make version override was in edee502 in Apr 2015.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Maintainer: @vrthra

@ofborg ofborg bot requested review from andir, edolstra, lovek323, np and vrthra April 29, 2020 07:58
@FRidh FRidh added this to WIP in Staging via automation May 1, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging May 1, 2020
@Ma27 Ma27 requested a review from fpletz May 6, 2020 19:06
@FRidh FRidh merged commit 0cfe9f3 into NixOS:staging Jul 2, 2020
Staging automation moved this from Needs review to Done Jul 2, 2020
vcunat added a commit that referenced this pull request Jul 6, 2020
@vcunat
gnumake42: bring this version back
e978eb5 
This is almost a revert of commit 0cfe9f3 (PR #86293).  Version 4.3
https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00004.html
brought some incompatibilities, so this will be useful for shorter-term
workarounds.
@vcunat
Copy link
Member

vcunat commented Jul 6, 2020 •
edited

The last time a package needed a make version override was in edee502 in Apr 2015.

Well, this bump actually forced the need for make version override :-)
(for now just bb9f138, but I expect more will come)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

@edolstra edolstra Awaiting requested review from edolstra

@lovek323 lovek323 Awaiting requested review from lovek323

@np np Awaiting requested review from np

@vrthra vrthra Awaiting requested review from vrthra

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chkno @vcunat @FRidh