Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/printers: fix example for hardware.printers.ensurePrinters.*.model #86253

Merged
merged 1 commit into from Jun 20, 2020
Merged

nixos/printers: fix example for hardware.printers.ensurePrinters.*.model #86253

merged 1 commit into from Jun 20, 2020

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Apr 28, 2020 •
edited

Motivation for this change

The version typo just cost me 30min ;)

nix-repl> lib.version.majorMinor "1.2.3"
error: value is a string while a set was expected, at (string):1:1

nix-repl> lib.versions.majorMinor "1.2.3"
"1.2"
Things done

It's lib.versions, not lib.version. Also I'm really sure that it's supposed to be the current version of Gutenprint, not Cups, as that's what lpinfo -m says on my system (and it works).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
nixos/printers: fix example for hardware.printers.ensurePrinters.*.model
6a77134 
It's `lib.versions`, not `lib.version`. Also I'm really sure that it's
supposed to be the current version of Gutenprint, not Cups, as thats
what `lpinfo -m` says on my system.
@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 28, 2020
florianjacob
florianjacob approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@florianjacob florianjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both fixes are correct and justified.
I already fixed them in my actual configuration, but forgot that there's the example. :(

@erictapen thanks alot for the fixes, and I'm sorry for the 30 minutes! 🍻

@rnhmjoj rnhmjoj merged commit 34f19a4 into NixOS:master Jun 20, 2020
@erictapen
Copy link
Member Author

Thanks for merging!

@florianjacob florianjacob mentioned this pull request Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florianjacob florianjacob florianjacob approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erictapen @florianjacob @rnhmjoj @worldofpeace