lapin amqp implementation #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
approved these changes
Apr 28, 2020
ofborg/src/easylapin.rs
Outdated
|
|
||
| pub fn from_config(cfg: &RabbitMQConfig) -> Result<CloseOnDrop<Connection>, lapin::Error> { | ||
| let opts = ConnectionProperties::default(); | ||
| // TODO version |
There was a problem hiding this comment.
We'll definitely want this to-done for merge
cole-h
reviewed
Apr 28, 2020
LnL7
force-pushed
the
lapin
branch
2 times, most recently
from
d9c98e2
to
3b35c7a
Compare
An async amqp library, but more importantly unlike the current amqp library it implements heartbeats.
This isn't very nice, but should implement everything needed to drop in lapin as the amqp library.
This is probably the safest thing to start with since it can be tested separately from the main deployment and isn't only used for secondary checks.
Many of these are actually not used, probably better to remove them.
Mostly the same behaviour, but the result syntax is a bit nicer.
Might help a little bit with debugging if any of these unexpected cases occur.
cole-h
reviewed
Apr 29, 2020
cole-h
approved these changes
Apr 29, 2020
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at switching the amqp library to improve hearbeats.