Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron_3: refactor #86230

Merged
merged 2 commits into from Jun 7, 2020
Merged

electron_3: refactor #86230

merged 2 commits into from Jun 7, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 28, 2020

Motivation for this change

This PR refactors electron_3 - essentially it allows us to remove the need for the separate electron/3.x.nix.

After the #86228 is merged, there will be only one dependency of electron_3 called obinskit, which is modified in this PR to match the new packaging from electron/default.nix.

IOW, the #86228 needs to be merged first.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@Shou Shou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that obinskit works on NixOS x86_64. LGTM.

@mmahut
Copy link
Member

mmahut commented May 10, 2020

@GrahamcOfBorg build electron_3 obinskit

1 similar comment
@prusnak
Copy link
Member Author

prusnak commented May 13, 2020

@GrahamcOfBorg build electron_3 obinskit

@ofborg ofborg bot requested a review from Shou May 13, 2020 16:03
@mmahut
Copy link
Member

mmahut commented Jun 7, 2020

@GrahamcOfBorg build electron_3

@prusnak
Copy link
Member Author

prusnak commented Jun 7, 2020

The aarch64 failure of electron_3 is present on master too: https://hydra.nixos.org/build/120910216 so it is not a regression.

Filed a patchelf issue here: NixOS/patchelf#208

@mmahut mmahut merged commit 9ed9140 into NixOS:master Jun 7, 2020
@prusnak prusnak deleted the electron-cleanup branch June 7, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants