Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amdadl-sdk, amdapp-sdk: remove #86233

Merged
merged 1 commit into from Apr 29, 2020
Merged

amdadl-sdk, amdapp-sdk: remove #86233

merged 1 commit into from Apr 29, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 28, 2020 •
edited

Motivation for this change

These libraries are obsolete (last upstream 3.0 update happened in 2015 and even this version was not packaged, latest was 2.8 in the nixpkgs).

Nothing in the nixpkgs tree requires them.

The only package requiring them - cgminer - was fixed in #61823 to use OpenCL

Let's remove this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
amdadl-sdk, amdapp-sdk: remove
d94444e 
these libraries are obsolete and nothing in the nixpkgs tree requires them
@prusnak prusnak mentioned this pull request Apr 28, 2020
Closed
@cole-h
Copy link
Member

cole-h commented Apr 28, 2020

@ofborg eval

Seems stalled; retry.

@offlinehacker offlinehacker merged commit d3ef065 into NixOS:master Apr 29, 2020
@prusnak prusnak deleted the remove-amd-legacy branch April 30, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker offlinehacker approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @cole-h @offlinehacker