libusb → libusb-compat-0_1, libusb1 ⇠ libusb #86165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until recently, libusb-compat propagated libusb1 and many packages unknowingly used it to obtain libusb1. When NixOS#82944 removed this evil propagation, it broke many packages with such incorrect assumption. This patch trades the breakage of packages wanting libusb1 caused by the PR for a hopefully less common breakage of the packages relying on the compat library.
jtojnar
changed the title
flokli
approved these changes
Apr 28, 2020
prusnak
reviewed
Apr 28, 2020
| @@ -26,7 +26,7 @@ stdenv.mkDerivation rec { | |||
| boost miniupnpc openssl unbound | |||
| cppzmq zeromq pcsclite readline | |||
| libsodium hidapi randomx rapidjson | |||
| pythonProtobuf libusb | |||
There was a problem hiding this comment.
Are you sure about this? The code seems to be looking for libusb-1.0:
(same for monero-gui)
There was a problem hiding this comment.
Then it must be broken on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Until recently,
libusb-compatpropagatedlibusb1and many packages unknowingly used it to obtainlibusb1. When #82944 removed this evil propagation, it broke many packages with such incorrect assumption. This patch trades the breakage of packages wanting libusb1 caused by the PR for a hopefully less common breakage of the packages relying on the compat library.cc @flokli @samueldr @worldofpeace