Skip to content

lutris: add gtk3 and glib setup hooks #86281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

lutris: add gtk3 and glib setup hooks #86281

wants to merge 1 commit into from
+4 −1

Conversation

samlich
Copy link
Contributor

@samlich samlich commented Apr 29, 2020

Motivation for this change

#78439 (review)

Also the glib-networking Gog fix was not working for @aanderse. Can you please check that this resolves it?

Things done

Added gtk3 and glib to nativeBuildInputs for their setup hooks.

gtk3 adds a variable which may be relevant to pixbuf

+export GDK_PIXBUF_MODULE_FILE='/nix/store/88v2qm0ivij7ynybzh8zfpz9ar3dkyjl-gdk-pixbuf-2.40.0/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache'

and glib adds paths for gsettings, I'm not sure how/if they are used

+export XDG_DATA_DIRS='/nix/store/78x2nyfhhili5ijd6l74z3flj63p92s0-gsettings-desktop-schemas-3.36.0/share/gsettings-schemas/gsettings-desktop-schemas-3.36.0:/nix/store/6yrlycwcnxlgg6bkhq4jvwmahyrj00id-gtk+3-3.24.17/share/gsettings-schemas/gtk+3-3.24.17'${XDG_DATA_DIRS:+':'}$XDG_DATA_DIRS
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@samlich samlich mentioned this pull request Apr 29, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from a user April 29, 2020 02:43
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 29, 2020
@aanderse
Copy link
Member

Sure I'll give this a try tomorrow. Thanks for the ping.

@samlich
Copy link
Contributor Author

samlich commented Apr 30, 2020

Sure I'll give this a try tomorrow. Thanks for the ping.

Thanks. I've moved them from nativeBuildInputs to buildInputs. If it doesn't work, maybe also try with them in nativeBuildInputs.

@aanderse
Copy link
Member

I can't build your branch:

building '/nix/store/1wd8xs3q1qipgb95gwqhhmdl53gk53rr-steamrt-legacy.deb.drv'...
building '/nix/store/fwy2hv5i9rri6ymv905cq84np32afyx8-vulkan-utils-multiarch.deb.drv'...
collision between `/nix/store/9m35bak59zy72kkyq4h89y6h39ighl3s-gtk+3-3.24.17/bin/gtk-update-icon-cache' and `/nix/store/z48f0dyzv4a6cbsf2nkpzk42rp93s23s-gtk+-2.24.32/bin/gtk-update-icon-cache'

trying http://repo.steampowered.com/steamrt/pool/main/s/steam-runtime-tools/steam-runtime-tools-bin_0.20200109.0-0+steamrt1.1+srt1_amd64.deb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
building '/nix/store/1ga77sxq9ppss4x56ngxs1qbsqn8agrs-waffle-utils.deb.drv'...

trying http://repo.steampowered.com/steamrt/pool/main/s/steamrt/steamrt-legacy_1.20200128.0+srt1_amd64.deb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found

trying https://public.abbradar.moe/steamrt/pool/main/s/steam-runtime-tools/steam-runtime-tools-bin_0.20200109.0-0+steamrt1.1+srt1_amd64.deb

Sorry, I don't have time to debug this at the moment 😞

@worldofpeace
Copy link
Contributor

Just rebase, the runtime was updated since they 404'd #86358

@aanderse
Copy link
Member

Screenshot_20200430_143150

With this branch I (still) get a blank GOG window when trying to install a game 😞 The Cannot create EGL window surface: EGL_BAD_MATCH message seems like it might be particularly relevant...

@samlich
Copy link
Contributor Author

samlich commented May 3, 2020

Oh, I thought you meant it still gave the ssl error. I've updated this to use the proper fix, so it might work now, but I think this is a separate issue with gtk webkit not detecting the supported features of your desktop environment.

@aanderse
Copy link
Member

aanderse commented May 3, 2020

@samlich I agree, completely different issue.

@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@zeorin
Copy link
Contributor

zeorin commented Apr 5, 2021

@aanderse did you ever find a solution to the blank GOG window?

@aanderse
Copy link
Member

aanderse commented Apr 5, 2021

@zeroin I don't believe I did. I just played games that didn't require lutris... seemed like a better effort-to-reward ratio 🤷‍♂️

@stale
Copy link

stale bot commented Oct 12, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 12, 2021
@samlich
Copy link
Contributor Author

samlich commented Oct 20, 2021

Closing as I don't think there is interest.

@samlich samlich closed this Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@samlich @aanderse @worldofpeace @zeorin @ryantm