Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish: 3.1.1 -> 3.1.2 #86285

Merged
merged 1 commit into from Apr 29, 2020
Merged

fish: 3.1.1 -> 3.1.2 #86285

merged 1 commit into from Apr 29, 2020
+3 −3

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Apr 29, 2020 •
edited

fish-shell/fish-shell@3.1.1...3.1.2

"This release of fish fixes a major issue discovered in fish 3.1.1:
Commands such as fzf and enhancd, when used with eval, would hang.
eval buffered output too aggressively, which has been fixed."

Motivation for this change

Major issue regarding tools like fzf and enhancd was fixed in this release. Unfortunately, the macOS CMake fix didn't make it for this one. Finally remembered to add myself as maintainer this time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
fish: 3.1.1 -> 3.1.2
7a15b60 
fish-shell/fish-shell@3.1.1...3.1.2

"This release of fish fixes a major issue discovered in fish 3.1.1:
Commands such as `fzf` and `enhancd`, when used with `eval`, would hang.
`eval` buffered output too aggressively, which has been fixed."
@ofborg ofborg bot requested a review from ocharles April 29, 2020 04:39
@worldofpeace worldofpeace merged commit d67d074 into NixOS:master Apr 29, 2020
@cole-h cole-h deleted the fish branch April 29, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocharles ocharles Awaiting requested review from ocharles

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @worldofpeace