Skip to content

Update Electron 6,7,8 #86237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2020
Merged

Update Electron 6,7,8 #86237

merged 4 commits into from
May 21, 2020
+19 −19

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 28, 2020 •
edited
Loading

Motivation for this change

Update Electron 6,7,8 to latest stable releases:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@worldofpeace
Copy link
Contributor

These fix CVE's so I believe we should backport them.

@prusnak prusnak added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 28, 2020
@prusnak prusnak force-pushed the electron-update branch from c589faa to b500911 Compare May 2, 2020 08:59
@prusnak
Copy link
Member Author

prusnak commented May 2, 2020

Updated PR to include the latest electron releases 7.2.4 and 8.2.5.

@prusnak prusnak force-pushed the electron-update branch from b500911 to 6b8ab28 Compare May 8, 2020 09:23
@prusnak
Copy link
Member Author

prusnak commented May 8, 2020

Updated PR to include the latest electron release 6.1.11

@prusnak prusnak requested review from travisbhartwell and manveru May 8, 2020 09:24
@prusnak prusnak added the 1.severity: security Issues which raise a security issue, or PRs that fix one label May 10, 2020
@prusnak
Copy link
Member Author

prusnak commented May 10, 2020

All releases include security fixes, adding the security label. Once these changes are in master, I will create a PR to stable.

ajs124
ajs124 approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@ajs124 ajs124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prusnak prusnak force-pushed the electron-update branch from 6b8ab28 to 8d08b2d Compare May 16, 2020 12:55
@prusnak
Copy link
Member Author

prusnak commented May 16, 2020

Updated PR to include the latest electron releases 7.3.0 and 8.3.0

@prusnak prusnak force-pushed the electron-update branch from 8d08b2d to 3f6698b Compare May 19, 2020 13:01
@prusnak
Copy link
Member Author

prusnak commented May 19, 2020 •
edited
Loading

Updated PR to include the latest electron release 6.1.12

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label May 19, 2020
@prusnak
Copy link
Member Author

prusnak commented May 19, 2020 •
edited
Loading

All 3 releases have CVE fixes in them. Please let's get this merged ASAP, so we can backport this to stable.

Security: backported fix for CVE-2020-6457: Use after free in speech recognizer.
Security: backported fix for CVE-2020-6458: Out of bounds read and write in PDFium.
Security: backported fix for CVE-2020-6459: Use after free in payments.
Security: backported fix for CVE-2020-6460: Insufficient data validation in URL formatting.
Security: backported fix for CVE-2020-6461: use-after-free in storage.
Security: backported fix for CVE-2020-6462: Use after free in task scheduling.
Security: backported fix for CVE-2020-6463: use-after-free in Angle.
Security: backported fix for CVE-2020-6464: Type confusion in blink.
Security: backported fix for CVE-2020-6831: Stack buffer overflow in SCTP.

@mmahut mmahut merged commit 6a205d6 into NixOS:master May 21, 2020
@prusnak prusnak deleted the electron-update branch May 21, 2020 21:34
@prusnak prusnak mentioned this pull request May 21, 2020
Merged
10 tasks
@prusnak
Copy link
Member Author

prusnak commented May 21, 2020

Thanks @mmahut!

Backport to stable in #88550

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124

@travisbhartwell travisbhartwell

@manveru manveru

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@prusnak @worldofpeace @ajs124 @mmahut @erictapen