treewide: fix modules options types where the default is null #86236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They can be caught with
nixos-option -r
on an empty ({...}:{}
) NixOSconfiguration with warning like:
They are actually the only kind of type error I get when using an empty configuration (not that bad!).
Obviously, most of the corrected options work well with
null
value, their implementation performs the check.An indirect one is
hardware.parallels.package
which defaults toconfig.boot.kernelPackages.prl-tools
.prl-tools
is defined asnull
inall-packages.nix
if kernel version is older than 4.15.Motivation for this change
Correct options types, remove warnings.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)