Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fasttext: 0.9.1 -> 0.9.2 #86193

Merged
merged 3 commits into from Apr 28, 2020
Merged

fasttext: 0.9.1 -> 0.9.2 #86193

merged 3 commits into from Apr 28, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog:

https://github.com/facebookresearch/fastText/releases/tag/v0.9.2

The second commit changes the python3Packages.fasttext derivation to use the pname, version, and src attributes from the fasttext derivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 28, 2020

Result of nixpkgs-review pr 86193 1

4 packages built:
- fasttext
- python27Packages.fasttext
- python37Packages.fasttext
- python38Packages.fasttext

@Mic92 Mic92 merged commit f66d5bc into NixOS:master Apr 28, 2020
@danieldk danieldk deleted the fasttext-0.9.2 branch April 28, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @Mic92