Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdirsyncer: fix build #86210

Merged
merged 2 commits into from May 1, 2020
Merged

vdirsyncer: fix build #86210

merged 2 commits into from May 1, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Apr 28, 2020

Motivation for this change

https://hydra.nixos.org/build/117749868

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from gebner and loewenheim April 28, 2020 14:00
@marsam
Copy link
Contributor Author

marsam commented Apr 29, 2020

@GrahamcOfBorg build vdirsyncer vdirsyncerStable

1 similar comment
@marsam
Copy link
Contributor Author

marsam commented Apr 30, 2020

@GrahamcOfBorg build vdirsyncer vdirsyncerStable

@doronbehar
Copy link
Contributor

I also wanted to do that but I wasn't thinking of deselecting these tests like that. Nice 👍. Unfortunately my PR got stale: #85993 :/

Br1ght0ne
Br1ght0ne approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
nixpkgs-review passed
vdirsyncer --version works

[6 built, 107 copied (338.8 MiB), 71.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/86210
3 packages built:
khal vdirsyncer vdirsyncerStable

@marsam marsam merged commit a8e8f23 into NixOS:master May 1, 2020
@marsam marsam deleted the fix-vdirsyncer branch May 1, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@gebner gebner Awaiting requested review from gebner

@loewenheim loewenheim Awaiting requested review from loewenheim

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @doronbehar @Br1ght0ne