Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4l2loopback: 0.12.4 -> 0.12.5 #86209

Merged
merged 1 commit into from Apr 29, 2020
Merged

v4l2loopback: 0.12.4 -> 0.12.5 #86209

merged 1 commit into from Apr 29, 2020

Conversation

jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Apr 28, 2020

Motivation for this change

Updates v4l2loopback to version 0.12.5, which is the latest. I originally did this because of umlaeute/v4l2loopback#257.

Things done

Builds on master and 7c399a4. Tested on 7c399a4 (using nixos-rebuild test -I nixos-unstable=./.).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • Appears to have decreased (?) by about 400 bytes. But likely I'm just doing something incorrectly. the closure size shouldn't really change anyway.
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from domenkozar April 28, 2020 13:57
@bjornfor bjornfor merged commit d21cc14 into NixOS:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakobrs @bjornfor