Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nixos/prometheus] promTypes.filter.value -> promTypes.filter.values #86239

Merged
merged 1 commit into from Feb 27, 2021
Merged

[nixos/prometheus] promTypes.filter.value -> promTypes.filter.values #86239

merged 1 commit into from Feb 27, 2021

Conversation

tathougies
Copy link
Contributor

Motivation for this change

The new configuration name for this is plural. Currently, attempting to enable ec2 SD results in a promtool check config error

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tathougies
[nixos/prometheus] promTypes.filter.value -> promTypes.filter.values
8389fb8 
The new configuration name for this is plural. Currently, attempting to enable ec2 SD results in a `promtool check config` error
@stale
Copy link

stale bot commented Oct 26, 2020

Nixpkgs stale bot info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 26, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 27, 2021
@MrRacoon
Copy link

@benley @fpletz @globin @WilliButz @Frostman

I'm new to nixpkgs, do y'all as maintainers have the perms to bless this through?

@matthewbauer
Copy link
Member

Looks good. BTW I don't think this was ever "value" singular; first commit uses values:

prometheus/prometheus@be85ba3

@matthewbauer matthewbauer merged commit c168e05 into NixOS:master Feb 27, 2021
@MrRacoon MrRacoon mentioned this pull request Feb 27, 2021
Closed
@matthewbauer
Copy link
Member

Cherry picked to 20.03 in 462c6fe

and in 20.09 in 3130543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrRacoon MrRacoon MrRacoon approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tathougies @MrRacoon @matthewbauer