Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitlab: Fix services.gitlab.enableStartTLSAuto #86173

Merged
merged 1 commit into from Apr 28, 2020
Merged

nixos/gitlab: Fix services.gitlab.enableStartTLSAuto #86173

merged 1 commit into from Apr 28, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Apr 28, 2020 •
edited

Motivation for this change

toString false results in an empty string, which, in this context,
is a syntax error. Use boolToString instead.

Fixes #86160

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz
nixos/gitlab: Fix services.gitlab.enableStartTLSAuto
c0a838d 
'toString false' results in an empty string, which, in this context,
is a syntax error. Use boolToString instead.

Fixes NixOS#86160
@talyz
Copy link
Contributor Author

talyz commented Apr 28, 2020

@GrahamcOfBorg test gitlab

@talyz talyz merged commit 0043181 into NixOS:master Apr 28, 2020
@talyz talyz deleted the gitlab-enable-starttlsauto branch April 28, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gitlab: service doesn't start when enableStartTLSAuto is set to false
1 participant
@talyz