Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

foldingathome: 7.5.1 -> 7.6.9 #86171

Merged
merged 1 commit into from Apr 28, 2020
Merged

foldingathome: 7.5.1 -> 7.6.9 #86171

merged 1 commit into from Apr 28, 2020

Conversation

evils
Copy link
Member

@evils evils commented Apr 28, 2020

Motivation for this change

the 2 year old version finally got an update
it allows prioritizing COVID-19 work and includes "important bug fixes and security updates"

Things done

bump fahclient, fahcontrol and fahviewer to 7.6.1

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • those numbers seem to have gone down, this checklist item needs clarification...
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from zimbatm April 28, 2020 06:49
bcdarwin
bcdarwin approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a rather strange package so I can't say whether anything can or should be changed/updated but it builds and runs fine for me on NixOS.

@zimbatm zimbatm merged commit e257a92 into NixOS:master Apr 28, 2020
@evils evils deleted the foldingathome branch April 29, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdarwin bcdarwin bcdarwin approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evils @bcdarwin @zimbatm