Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coturn: apply patch for CVE-2020-6061/6062 #86268

Merged
merged 1 commit into from Apr 29, 2020
Merged

coturn: apply patch for CVE-2020-6061/6062 #86268

merged 1 commit into from Apr 29, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Apr 28, 2020 •
edited

Motivation for this change

Fixes: CVE-2020-6061, CVE-2020-6062

An exploitable heap overflow vulnerability exists in the way CoTURN
4.5.1.1 web server parses POST requests. A specially crafted HTTP
POST request can lead to information leaks and other misbehavior.
An attacker needs to send an HTTPS request to trigger this vulnerability.

An exploitable denial-of-service vulnerability exists in the way
CoTURN 4.5.1.1 web server parses POST requests. A specially crafted
HTTP POST request can lead to server crash and denial of service.
An attacker needs to send an HTTP request to trigger this vulnerability.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt mentioned this pull request Apr 28, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from Ralith April 28, 2020 23:23
@rasendubi
Copy link
Member

fails to build:

hash mismatch in fixed-output derivation '/nix/store/1yq0fs91z4bidnsh3mbrfkrw5w5ky1i9-CVE-2020-6061+6062.patch':
  wanted: sha256:0wsja9bahmyscigp6wfbwsn8dxbg92cnv8gm298k97yg3330lb29
  got:    sha256:0fcy1wp91bb4hlhnp96sf9bs0d9hf3pwx5f7b1r9cfvr3l5c1bk2

Also, 19.09 backport is here: #86271

@mweinelt

This comment has been minimized.

Sign in to view
@mweinelt
coturn: apply patch for CVE-2020-6061/6062
704a018 
Fixes: CVE-2020-6061, CVE-2020-6062

An exploitable heap overflow vulnerability exists in the way CoTURN
4.5.1.1 web server parses POST requests. A specially crafted HTTP
POST request can lead to information leaks and other misbehavior.
An attacker needs to send an HTTPS request to trigger this vulnerability.

An exploitable denial-of-service vulnerability exists in the way
CoTURN 4.5.1.1 web server parses POST requests. A specially crafted
HTTP POST request can lead to server crash and denial of service.
An attacker needs to send an HTTP request to trigger this vulnerability.
@mweinelt
Copy link
Member Author

Fixed.

@rasendubi rasendubi merged commit de83c2d into NixOS:master Apr 29, 2020
@mweinelt mweinelt deleted the coturn/CVE-2020-6061+6062 branch April 29, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Awaiting requested review from Ralith

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @rasendubi