skypeforlinux: 8.58.0.93 -> 8.59.0.77 #86256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
peterhoeg
changed the title
jraygauthier
suggested changes
Apr 29, 2020
There was a problem hiding this comment.
Unless there is a good reason not to, I would prioritize the mirror.cs.uchicago.edu mirror over the web.archive.org as it is much faster (factor 30x at least).
I tested that all mirrors are able to equally retrieve the deb bundle and resolve to the same sha:
$ version="8.59.0.77"
$ nix-prefetch-url "https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_${version}_amd64.deb"
[77.1 MiB DL]
path is '/nix/store/94v5ixlpdnbsrw3m5s7y5m7mwycv9wpg-skypeforlinux_8.59.0.77_amd64.deb'
1cnlwlp84942ywji3x60zvhijavazdxfym3rfzq3ysky28b6mn6i
$ nix-prefetch-url "https://web.archive.org/web/https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_${version}_amd64.deb"
[77.1 MiB DL]
path is '/nix/store/94v5ixlpdnbsrw3m5s7y5m7mwycv9wpg-skypeforlinux_8.59.0.77_amd64.deb'
1cnlwlp84942ywji3x60zvhijavazdxfym3rfzq3ysky28b6mn6i
$ nix-prefetch-url "https://mirror.cs.uchicago.edu/skype/pool/main/s/skypeforlinux/skypeforlinux_${version}_amd64.deb"[77.1 MiB DL]
path is '/nix/store/94v5ixlpdnbsrw3m5s7y5m7mwycv9wpg-skypeforlinux_8.59.0.77_amd64.deb'
1cnlwlp84942ywji3x60zvhijavazdxfym3rfzq3ysky28b6mn6iBinary still to be tested.
|
Binary compiles and runs fine: $ gh pr checkout bachp:skypeforlinux-8.59.0.77
# ..
Switched to branch 'skypeforlinux-8.59.0.77'
$ nix-shell -I nixpkgs=. -p skypeforlinux
these derivations will be built:
/nix/store/271mhjwb997wxvyk3mc6lln1g3zyng4w-skypeforlinux-8.59.0.77.drv
these paths will be fetched (9.60 MiB download, 47.14 MiB unpacked):
# ..
$ which skypeforlinux
/nix/store/wklixy1636hby73ah2s6f0k8i6n4w2lc-skypeforlinux-8.59.0.77/bin/skypeforlinux
$ skypeforlinux
Fontconfig warning: "/etc/fonts/fonts.conf", line 86: unknown element "blank"
(electron) 'setZoomLevel function' is deprecated and will be removed. Please use 'zoomLevel property' instead.
(electron) 'getZoomLevel function' is deprecated and will be removed. Please use 'zoomLevel property' instead.
(electron) 'setBadgeCount function' is deprecated and will be removed. Please use 'badgeCount property' instead.
ioctl failed for wlan0, errno = 19 (No such device)
ioctl failed for wlp2s0, errno = 19 (No such device)
ioctl failed for wlp3s0, errno = 19 (No such device)
|
|
LGTM. Remains to see what we do with the mirror ordering (see above recommendation). |
|
I have tested and this works fine. |
The university of chigaco keeps the binaries of old releases. This reduces the change of NixOS#81868 and NixOS#85724 happening again in the future.
bachp
force-pushed
the
skypeforlinux-8.59.0.77
branch
from
0375529
to
e4aab9c
Compare
|
Mirror order changed. |
10 tasks
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest skype version.
In addition the university of chicago is added as an additional mirror to try to fetch
the binary from. This reduces the change of #81868 and #85724 happening again in the
future. This might also be a good candidate to backport to stable releases.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)