Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: 3.5.385850.0413 -> 5.0.398100.0427 #86255

Merged
merged 1 commit into from Apr 28, 2020
Merged

zoom-us: 3.5.385850.0413 -> 5.0.398100.0427 #86255

merged 1 commit into from Apr 28, 2020

Conversation

lovesegfault
Copy link
Member

@lovesegfault lovesegfault commented Apr 28, 2020 •
edited

Motivation for this change

https://zoom.us/docs/en-us/zoom-v5-0.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault lovesegfault requested review from worldofpeace and NeQuissimus and removed request for worldofpeace April 28, 2020 20:54
@ofborg ofborg bot requested review from danbst and tadfisher April 28, 2020 21:01
@worldofpeace
Copy link
Contributor

According to their release notes action is required where everyone must update to this version.
This unfortunately means we must backport the update to both 19.09 and 20.03 right away.

@prusnak prusnak added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 28, 2020
worldofpeace
worldofpeace approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@worldofpeace worldofpeace merged commit f5c04ec into NixOS:master Apr 28, 2020
@lovesegfault lovesegfault deleted the zoom-us-5.0 branch April 28, 2020 22:02
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Apr 29, 2020
@worldofpeace @dtzWill
Merge pull request NixOS#86255 from lovesegfault/zoom-us-5.0
a0f6f01 
zoom-us: 3.5.385850.0413 -> 5.0.398100.0427
(cherry picked from commit f5c04ec)
@Ekleog
Copy link
Member

Ekleog commented May 1, 2020

@worldofpeace I see you merged but did not backport (yet) to 19.09 / 20.03 despite what you said. Is that on purpose, or just something forgotten about as we all regularly do?

@worldofpeace
Copy link
Contributor

@Ekleog Oh, I meant comment to ask if @lovesegfault could do this (I typically think it's good idea to have a contributor take that responsibility). I will do this now.

@worldofpeace
Copy link
Contributor

20.03 #86502

@Ekleog
Copy link
Member

Ekleog commented May 2, 2020

Thank you! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

@danbst danbst Awaiting requested review from danbst

@tadfisher tadfisher Awaiting requested review from tadfisher

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lovesegfault @worldofpeace @Ekleog @prusnak