Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkDerivation mesonFlags: Fix cross file logic to handle more cases #86254

Merged
merged 1 commit into from Apr 28, 2020
Merged

mkDerivation mesonFlags: Fix cross file logic to handle more cases #86254

merged 1 commit into from Apr 28, 2020

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Otherwise eval breaks

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ericson2314
Copy link
Member Author

Ah, of borg won't tell me I fixed it when it was previous broken.

@Ericson2314 Ericson2314 merged commit d78e0c7 into NixOS:staging Apr 28, 2020
@Ericson2314 Ericson2314 deleted the fix-staging-eval branch April 28, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @matthewbauer