Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webcamoid: init at 8.7.1 #86261

Merged
merged 2 commits into from May 23, 2020
Merged

webcamoid: init at 8.7.1 #86261

merged 2 commits into from May 23, 2020

Conversation

robaca
Copy link
Contributor

@robaca robaca commented Apr 28, 2020 •
edited

Expression for packaging webcamoid (https://webcamoid.github.io/)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@robaca
Copy link
Contributor Author

robaca commented Apr 29, 2020

related to package request #84890

@robaca robaca mentioned this pull request Apr 29, 2020
Closed
@robaca
Copy link
Contributor Author

robaca commented May 15, 2020

Is there missing something in the MR to be eligible for a review?

aanderse
aanderse requested changes May 15, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a large backlog of PRs, unfortunately. I haven't looked at the qt stuff in a bit so I can't offer more advice, but I'm a bit confused by the preFixup and INSTALLQMLDIR bit (not saying it is wrong, I'm really just not familiar).

Maybe a wonderful person who is much more knowledgeable than myself and volunteers themselves for PR reviews, like @jonringer, would be willing to take a look.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/video/webcamoid/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/webcamoid/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/webcamoid/default.nix Outdated Show resolved Hide resolved
@robaca robaca requested a review from aanderse May 22, 2020 08:47
@aanderse
Copy link
Member

aanderse commented May 22, 2020 •
edited

@GrahamcOfBorg build webcamoid

@aanderse
Copy link
Member

@robaca can you please squash the last 2 commits into a single and have it as webcamoid: init at 8.7.1 as per CONTRIBUTING.MD.

@robaca
Copy link
Contributor Author

robaca commented May 22, 2020

@aanderse I fixed the commit history as requested.

@aanderse
Copy link
Member

@robaca thanks for you patience in all this and the great new package. Welcome to the team! 🎉

@aanderse aanderse merged commit dacd1e4 into NixOS:master May 23, 2020
@fgaz fgaz mentioned this pull request Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robaca @aanderse @Janik-Haag