New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keybase,kbfs,keybase-gui: 5.3.1 -> 5.4.2 #86185
Conversation
I wasn't sure whether to add myself to package maintainers or not, but I'd be happy to help maintaining these packages, so I did. Please let me know if I misunderstood. :P |
@bennofs I switched to base32 for the hash. I think this PR is ready. I've been using this version of Keybase for 5 days using an overlay: { config, ... }:
{
nixpkgs.overlays = [
(self: super: let
url = https://github.com/NixOS/nixpkgs/archive/3d067a7539860593cf60785e09d270c3c66c721f.tar.gz;
unstable = import (fetchTarball url) { config = config.nixpkgs.config; };
in {
keybase = unstable.keybase;
keybase-gui = unstable.keybase-gui;
kbfs = unstable.kbfs;
})
];
} |
Thanks! I'll do a quick smoketest and then merge tomorrow |
I just noticed this special treatment for Darwin: nixpkgs/pkgs/top-level/all-packages.nix Lines 4488 to 4495 in 2c1d9af
Introduced in #44698 Headers don't seem to have changed between Keybase versions, so I think we're good:
But I don't really understand what's going on there, and I can't test on Darwin. It might be worth testing on Darwin if someone can. 🤷♂️ |
Can anyone just request Graham of Borg to build the package? Should I try it? :o |
@GrahamcOfBorg build keybase kbfs keybase-gui |
Motivation for this change
Keybase version 5.4.x offers improved conflict resolution for KBFS. Running this version, I was able to resolve a long standing file conflict previously unresolvable due to various issues.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)I have tested these changes by manually running
keybase service
,kbfsfuse
, andkeybase-gui
and using the GUI to resolve some KBFS file conflicts I had, and send some chat messages. In doing so, I have verified that all the important bits are working.Binaries untested:
kbnm
inkeybase
git-remote-keybase
inkbfs
redirector
inkbfs
EDIT: I am running this in my system now via an overlay, and have used other features, including the encrypted git remotes. No problems encountered.