Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sound Open Firmware support, sof-firmware: init at 1.4.2, update kernel config #86168

Merged
merged 2 commits into from Apr 29, 2020
Merged

Sound Open Firmware support, sof-firmware: init at 1.4.2, update kernel config #86168

merged 2 commits into from Apr 29, 2020

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Apr 28, 2020 •
edited

Motivation for this change

Trying to get microphone working on X1 Carbon gen7, it requires Sound Open Firmware support, as it looks like all the new Intel machines will require it.

Additionally to updated alsa-lib (#83155), sof firmware files and updated kernel config enables dmic microphone support and sound in general using SOF.

I've tested those changes on kernel versions:

  • 5.4.35 buggy, it didn't work, I've tried tweaking configuration.nix following archwiki but it didn't help
  • 5.5.19 worked out of box, but there were some unrelated Intel DRI issues
  • 5.6.7 worked out of box, for now no issues

SOF kernel support is available from 5.2, but I suggest we leave it enabled from 5.5, dmesg looks scary in later versions.

Archlinux also enabled SOF in their default kernel config

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lblasc lblasc requested a review from flokli April 29, 2020 05:38
@lblasc lblasc changed the title sof-firmware: init at 1.4.2 Sound Open Firmware support, sof-firmware: init at 1.4.2, update kernel config Apr 29, 2020
@flokli flokli merged commit f046de4 into NixOS:staging Apr 29, 2020
@flokli
Copy link
Contributor

flokli commented Apr 29, 2020

Thanks!

@lblasc lblasc deleted the sof-firmware branch April 29, 2020 10:39
@phunehehe phunehehe mentioned this pull request May 16, 2020
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/install-sound-open-firmware/6535/5

@wmertens
Copy link
Contributor

the reason for the removal is discussed in thesofproject/linux#1780 (comment), basically just make sure to keep the common hdmi module enabled and all is well.

@jakobrs jakobrs mentioned this pull request Aug 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lblasc @flokli @nixos-discourse @wmertens @vcunat