Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopass-ui: init at 0.7.0 #86169

Closed
wants to merge 1 commit into from
Closed

gopass-ui: init at 0.7.0 #86169

wants to merge 1 commit into from
+16,504 −0

Conversation

jraygauthier
Copy link
Member

@jraygauthier jraygauthier commented Apr 28, 2020 •
edited
Loading

Motivation for this change

New package with no equivalent in nixpkgs.

Only proper frontend that I know of for gopass.
Qtpass kind of works, but not quite as well as this.
Gopass bridge only allows for read and add from the browser but no edit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 28, 2020
@prusnak
Copy link
Member

prusnak commented May 2, 2020

Please put the URL in the homepage field into quotes (RFC45).

@jraygauthier jraygauthier force-pushed the jrg/gopass-ui-init-0.7.0 branch from b3fccbb to 0e16673 Compare May 4, 2020 01:52
@jraygauthier
Copy link
Member Author

@prusnak : Done.

@jraygauthier jraygauthier force-pushed the jrg/gopass-ui-init-0.7.0 branch 4 times, most recently from 310e4ec to c234280 Compare June 27, 2020 23:35
@jraygauthier jraygauthier force-pushed the jrg/gopass-ui-init-0.7.0 branch from c234280 to e0360f1 Compare June 28, 2020 20:29
@ofborg ofborg bot requested a review from sikmir June 28, 2020 20:36
@jraygauthier jraygauthier mentioned this pull request Jun 30, 2020
Closed
@jraygauthier jraygauthier force-pushed the jrg/gopass-ui-init-0.7.0 branch 3 times, most recently from abb61ad to a3495b9 Compare July 2, 2020 01:32
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jul 2, 2020
@jraygauthier jraygauthier force-pushed the jrg/gopass-ui-init-0.7.0 branch 2 times, most recently from cc488be to 131c3d6 Compare July 7, 2020 02:45
@jraygauthier jraygauthier force-pushed the jrg/gopass-ui-init-0.7.0 branch from 131c3d6 to b70e78d Compare July 9, 2020 02:27
@ofborg ofborg bot requested a review from sikmir July 9, 2020 02:35
@jraygauthier jraygauthier force-pushed the jrg/gopass-ui-init-0.7.0 branch from b70e78d to 5e1cf2d Compare July 9, 2020 12:57
@ofborg ofborg bot requested a review from sikmir July 9, 2020 13:05
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@CMCDragonkai
Copy link
Member

What's the reason for not merging this?

@stale
Copy link

stale bot commented Aug 15, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 15, 2021
@jraygauthier
Copy link
Member Author

This version no longer working well with current nixpkgs. Had a hard time updating to latest. Might eventually decide to come back with something at some later point in time. However odds are that a better more lightweight gui is made available by this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jraygauthier @prusnak @CMCDragonkai @sikmir @ryantm