Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kinect-cpp-client: remove #86179

Merged
merged 1 commit into from Apr 28, 2020
Merged

kinect-cpp-client: remove #86179

merged 1 commit into from Apr 28, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 28, 2020

  • not updated since 2015
  • upstream has no releases since 2016
  • has no maintainer in nixpkgs
  • marked as insecure because of old openssl
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak requested changes Apr 28, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the commit message (kinetic-cpp-client vs kinect-cpp-client)

@Mic92
kinetic-cpp-client: remove
30d5f97 
- not updated since 2015
- upstream has no releases since 2016
- has no maintainer in nixpkgs
- marked as insecure because of old openssl
@Mic92 Mic92 merged commit b3cd4c1 into NixOS:master Apr 28, 2020
@Mic92 Mic92 deleted the kinect-cpp-client branch April 28, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @prusnak