Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/fish: prevent fish from generating completions on first run #86202

Merged
merged 1 commit into from Apr 28, 2020

Conversation

hyperfekt
Copy link
Contributor

@hyperfekt hyperfekt commented Apr 28, 2020

Motivation for this change

Previously fish would generate completions from man pages if the directory they are usually stored in does not exist (given that Python exists on the $PATH, see #86195 and fish-shell/fish-shell#6956). On NixOS, the system is responsible for creating those completions. If fish creates completions itself, completions for commands that don't exist would keep being considered by fish (since they aren't automatically updated like the ones generated by NixOS).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

@GrahamcOfBorg test fish

@adisbladis adisbladis merged commit 4a8a214 into NixOS:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants