Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gnome3: add docs #86288

Merged
merged 2 commits into from May 18, 2021
Merged

nixos/gnome3: add docs #86288

merged 2 commits into from May 18, 2021

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Apr 29, 2020 •
edited by jtojnar

Build with nix-build nixos/release.nix -A manualHTML.x86_64-linux

Motivation for this change

My gist in docbook (thank you pandoc) https://gist.github.com/worldofpeace/a908d45f3c504499fd8aa46a9ce09559, with slightly less typo's (probably not though 😁).

I need to write a short summary about gnome at the beginning.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/problem-with-configuration-nix-and-gnome3-settings/7006/2

hedning
hedning reviewed May 6, 2020
View reviewed changes
nixos/modules/services/x11/desktop-managers/gnome3.xml Outdated
</para>

<para>
However, it doesn’t work correctly for the wayland session of GNOME yet, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC it works with sddm at least, not sure what's the status for LightDM after the wayland session patches. Though I don't mind pushing people towards gdm (would be nice having gnome3.enable = true enable gdm by default, but that requires some reworking how we enable display-managers, so).

@worldofpeace worldofpeace mentioned this pull request Jun 23, 2020
Open
@Lassulus
Copy link
Member

can this be merged? looks fine to me

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/is-there-a-way-to-enable-some-gnome-extension-globally/8773/2

@jtojnar jtojnar mentioned this pull request Sep 12, 2020
Closed
@worldofpeace worldofpeace mentioned this pull request Oct 1, 2020
Merged
10 tasks
@worldofpeace worldofpeace mentioned this pull request Feb 27, 2021
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/debloating-gnome/11975/2

@github-actions github-actions bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 10, 2021
amaxine
amaxine approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@amaxine amaxine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this covers all the most important parts.

Maybe a mention of tracker/tracker-miners services would also be worth it? I personally disable both because I do not benefit from its features e.g. file indexing and so see them as a bit of a waste - but it would need a big warning about how much it breaks the core experience, e.g. gnome-music just not working at all.

I think a bigger warning about switching display managers would also be good at that point, as the default behaviour is fairly dangerous, since it won't lock on suspend, etc. Easy to overlook the way it's placed now.

worldofpeace and others added 2 commits May 11, 2021 18:10
@worldofpeace @jtojnar
nixos/gnome: add user docs
8ad5d65 
Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
@jtojnar
nixos/gnome: Allow disabling sysprof
8380ceb
@jtojnar
Copy link
Contributor

jtojnar commented May 11, 2021

Great idea, thanks. Added a section on disabling services and rewritten the enabling section to make GDM recommendation more explicit.

@jtojnar jtojnar added this to the 21.05 milestone May 11, 2021
@jtojnar jtojnar merged commit 1b1faeb into NixOS:master May 18, 2021
@jtojnar jtojnar deleted the gnome-doc branch May 18, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning left review comments

@jtojnar jtojnar jtojnar left review comments

@amaxine amaxine amaxine approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
21.05
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@worldofpeace @nixos-discourse @Lassulus @jtojnar @hedning @amaxine