Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman: Wrap packages required to run containers #86249

Merged
merged 2 commits into from Apr 29, 2020
Merged

podman: Wrap packages required to run containers #86249

merged 2 commits into from Apr 29, 2020

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Apr 28, 2020 •
edited

Motivation for this change

Closes #86245

Closure size for podman before:
/nix/store/0vdiml328w6frhl45r52px7kwxq6cpb4-podman-1.9.0-bin 135.8M
After:
/nix/store/sq5nw88ybrkx1c0c1zh8pi8s9ls78h2n-podman-1.9.0-bin 208.5M

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
Copy link
Member

cole-h commented Apr 28, 2020

@ofborg eval

I'm out of GitHub-bashing quips for now, so just take this eval.

@grahamc grahamc mentioned this pull request Apr 28, 2020
Closed
@ofborg ofborg bot requested a review from saschagrunert April 29, 2020 11:05
@adisbladis
Copy link
Member Author

@GrahamcOfBorg test podman

saschagrunert
saschagrunert approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vdemeester
vdemeester approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@adisbladis adisbladis merged commit f0c8331 into NixOS:master Apr 29, 2020
@zowoq
Copy link
Contributor

zowoq commented Apr 29, 2020

Sorry for the belated comment, this will conflict with the changes to buildGoPackage (#85535) in staging.

I'm not sure what I should do to resolve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@vdemeester vdemeester vdemeester approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@marsam marsam Awaiting requested review from marsam

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Podman packaging impurities
6 participants
@adisbladis @cole-h @zowoq @vdemeester @saschagrunert @worldofpeace