Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 1d8a149ccea7
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 2437cd6094ff
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Mar 26, 2020

  1. emacs-modes: build MELPA package sets without null packages

    The current algorithm creates attributes with null values for packages
    with no source in a variant of MELPA. Though will satify dependencies
    they produce no files, and though a build that transitively depends on
    one them will be successful, Emacs won't find them and any code
    depending on them won't work.
    
    The solution with minimal code change would have been filtering the
    list of results from melpaDerivation by comparing the value against
    null, but that leads to an infinite recursion.
    
    This commit also moves legacy renames from the shared to the unstable
    set, as the corresponding null value elements won't exist in the
    stable set anymore.
    
    The test used for the problem was:
    
      $ nix-build --show-trace ./default.nix -A emacs26Packages.melpaStablePackages.findr
      error: expression does not evaluate to a derivation (or a set or list of those)
    
    The expected output, obtained with this commit is:
    
      $ nix-build --show-trace ./default.nix -A emacs26Packages.melpaStablePackages.findr
      error: attribute 'findr' in selection path 'emacs26Packages.melpaStablePackages.findr' not found
    Servilio Afre Puentes committed Mar 26, 2020
    Copy the full SHA
    b2c8626 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. Merge pull request #86213 from afrepues/build-melpa-stable-with-no-nu…

    …ll-pkgs
    
    emacs-modes: build MELPA package sets without null packages
    adisbladis committed Apr 28, 2020
    Copy the full SHA
    2437cd6 View commit details
    Browse the repository at this point in the history