Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glibcCross: add arm entry for meson flags #86259

Closed
wants to merge 1 commit into from
Closed

glibcCross: add arm entry for meson flags #86259

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 28, 2020 •
edited

Motivation for this change

Fixes evaluation of pkgsCross.arm-embedded.newlibCross
in which it would produce the following error:

attribute 'arm' missing, at ... pkgs/stdenv/generic/make-derivation.nix:273:31

example error: https://gist.github.com/GrahamcOfBorg/0bd43f44fc2113856214c08ff5ddf4b8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
glibcCross: add arm entry for meson flags
aa08219 
Fixes evaluation of `pkgsCross.arm-embedded.newlibCross`
in which it would produce the following error:

```
attribute 'arm' missing, at ... pkgs/stdenv/generic/make-derivation.nix:273:31
```
@jonringer
Copy link
Contributor Author

proper fix was done : #86254 closing

@jonringer jonringer closed this Apr 28, 2020
@jonringer jonringer deleted the fix-staging branch April 28, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @cole-h