Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 19f171f70553
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1f1ca24d4eae
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Apr 28, 2020

  1. Copy the full SHA
    e75296f View commit details
  2. Merge pull request #2549 from pleroy/2548

    Detect non-ASCII paths as they confuse Mono
    pleroy authored Apr 28, 2020
    Copy the full SHA
    1f1ca24 View commit details
Showing with 7 additions and 0 deletions.
  1. +7 −0 ksp_plugin_adapter/loader.cs
7 changes: 7 additions & 0 deletions ksp_plugin_adapter/loader.cs
Original file line number Diff line number Diff line change
@@ -48,6 +48,13 @@ internal static string LoadPrincipiaDllAndInitGoogleLogging() {
string.Join("', '", possible_dll_paths) + "' in directory '" +
Directory.GetCurrentDirectory() + "'.";
}
foreach (char c in Directory.GetCurrentDirectory()) {
if (c >= 128) {
return Directory.GetCurrentDirectory() +
" contains the non-ASCII character " + c +
"; this is known to confuse Mono.";
}
}
try {
loaded_principia_dll_ = true;
Log.InitGoogleLogging();