Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbfd: fix build #86260

Merged
merged 1 commit into from Apr 29, 2020
Merged

libbfd: fix build #86260

merged 1 commit into from Apr 29, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 28, 2020 •
edited

Motivation for this change

The patch to separate it from binutils didn't apply anymore after
updating binutils to 2.34[1].

[1] #85951

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 mentioned this pull request Apr 28, 2020
Closed
10 tasks
lovesegfault
lovesegfault approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonringer
Copy link
Contributor

@GrahamcOfBorg build llvm_7

@Ma27
libbfd: fix build
7550ab9 
The patch to separate it from `binutils` didn't apply anymore after
updating `binutils` to 2.34[1].

[1] NixOS#85951
@Ma27
Copy link
Member Author

Ma27 commented Apr 28, 2020

@Ericson2314 updated. Missed that initially while resolving the conflicts :)

Ericson2314
Ericson2314 approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment fix!

@vcunat vcunat merged commit 1014c7c into NixOS:staging Apr 29, 2020
@Ma27 Ma27 deleted the fix-libbfd branch April 29, 2020 07:45
@flokli flokli mentioned this pull request Apr 29, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@vcunat vcunat vcunat approved these changes

@lovesegfault lovesegfault lovesegfault approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ma27 @jonringer @Ericson2314 @vcunat @lovesegfault