Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: reenable Hydra build #87580

Merged
merged 1 commit into from May 12, 2020
Merged

webkitgtk: reenable Hydra build #87580

merged 1 commit into from May 12, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

AFAICT, hydraPlatforms = [] serves no purpose for webkitgtk except making it more difficult to see if the build is succeeding on Hydra. The package is still built and hold up channels because many other packages depend on it.

See 8726c6d for the commit that originally added this line.

cc @NixOS/gnome

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from hedning, jtojnar and worldofpeace May 11, 2020 05:28
vcunat
vcunat approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Borg shows the "newly built" paths: https://gist.github.com/GrahamcOfBorg/e07d085d4e7c4bde56d06d1d43e9f231

It's just a single derivation per platform (checked locally), and surely used as dependency in others that get built.

vcunat referenced this pull request May 11, 2020
@edolstra
webkitgtk: Disable Hydra build
8726c6d 
This package takes an excessive amount of time to build (e.g., right
now Hydra is showing eight concurrent builds of webkitgtk, some of
them running for more than 6 hours). This may also delay channel
updates.
@worldofpeace worldofpeace merged commit 1e3ff03 into NixOS:master May 12, 2020
@lopsided98 lopsided98 deleted the patch-2 branch May 12, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @vcunat @worldofpeace