Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg-full: setup addOpenGLRunpath #87588

Merged
merged 1 commit into from May 16, 2020
Merged

ffmpeg-full: setup addOpenGLRunpath #87588

merged 1 commit into from May 16, 2020

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

addOpenGLRunpath was missing in pkgs.ffmpeg-full, preventing users to make use of hardware acceleration when encoding.

Things done

Backported addOpenGLRunpath from pkgs.ffmpeg.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elohmeier elohmeier requested review from vcunat and codyopel May 11, 2020 09:11
@elohmeier
Copy link
Contributor Author

I think this fix should also be backported to 20.03.

@flokli
Copy link
Contributor

flokli commented May 14, 2020 •
edited

Hmm - the change to ffmpeg causes a large rebuild, so this would need to go via staging.

Could you drop the ffmpeg commit, and open this one into staging? Happy to backport the ffmpeg-full one into 20.03 (and the ffmpeg one into staging-20.03, once its merged)

@flokli flokli mentioned this pull request May 14, 2020
Merged
10 tasks
@elohmeier elohmeier mentioned this pull request May 16, 2020
Merged
10 tasks
@elohmeier
Copy link
Contributor Author

@flokli I've just split it up into another PR for ffmpeg (to staging), #87968.

@flokli
Copy link
Contributor

flokli commented May 16, 2020

I changed the addOpenGLRunpath $out/lib/lib….so* to addOpenGLRunpath $out/lib/lib….so, as there's only one "real" .so.X.Y.Z library, and the rest is less specific symlinks pointing to that file.

@flokli flokli merged commit 1f20788 into NixOS:master May 16, 2020
@flokli
Copy link
Contributor

flokli commented May 16, 2020

Backported to 20.03 in 885a665.

@elohmeier
Copy link
Contributor Author

Awesome, thanks!

@elohmeier elohmeier deleted the ffmpeg-addOpenGLRunpath branch May 17, 2020 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@bjornfor bjornfor bjornfor approved these changes

@vcunat vcunat Awaiting requested review from vcunat

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elohmeier @flokli @bjornfor