Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-nio: update #87610

Merged
merged 3 commits into from Jun 16, 2020
Merged

matrix-nio: update #87610

merged 3 commits into from Jun 16, 2020

Conversation

symphorien
Copy link
Member

Support for decrypting images in pantalaimon

Briefly tested pantalaimon.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from emilazy, Valodim and tilpner May 11, 2020 22:57
@emilazy
Copy link
Member

emilazy commented May 12, 2020

Result of nixpkgs-review pr 87610 1

3 packages built:
- pantalaimon
- python37Packages.matrix-nio
- weechatScripts.weechat-matrix

emilazy
emilazy approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weechat-matrix seems to work fine for me.

@emilazy emilazy mentioned this pull request May 12, 2020
Merged
10 tasks
@symphorien
Copy link
Member Author

Updated matrix-nio to 0.12.0.
Changelog https://github.com/poljar/matrix-nio/blob/master/CHANGELOG.md
Checked with pantalaimon that I could do interactive verification.

@symphorien symphorien requested a review from emilazy May 21, 2020 12:14
emilazy
emilazy approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been running this for a few days with weechat-matrix, seems fine to me.

@symphorien
Copy link
Member Author

Apparently pantalaimon was independently udpated elsewhere, remains only the matrix-nio update.

@symphorien symphorien changed the title pantalaimon, matrix-nio: update matrix-nio: update Jun 4, 2020
@ofborg ofborg bot requested a review from emilazy June 4, 2020 21:22
@Ekleog
Copy link
Member

Ekleog commented Jun 16, 2020

Thank you! :D

@Ekleog Ekleog merged commit 0b2bd1f into NixOS:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Valodim Valodim Awaiting requested review from Valodim

@tilpner tilpner Awaiting requested review from tilpner

@emilazy emilazy Awaiting requested review from emilazy

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@symphorien @emilazy @Ekleog