Renamed isnan() to IsReasonable #610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
suggested changes
May 11, 2020
src/solvespace.h
Outdated
| #ifndef isnan | ||
| # define isnan(x) (((x) != (x)) || (x > 1e11) || (x < -1e11)) | ||
| #ifndef IsReasonable | ||
| # define IsReasonable(x) (((x) != (x)) || (x > 1e11) || (x < -1e11)) |
There was a problem hiding this comment.
The whole point of renaming would be to get rid of a name collision and all this preprocessor junk. This function should be static inline inside namespace SolveSpace, like the WRAP ones.
There was a problem hiding this comment.
You want the WRAP one to be static too?
There was a problem hiding this comment.
Ah, I misremembered that it was already static. It makes zero difference either way. Just make them all the same.
There was a problem hiding this comment.
Done. unless you want the 3 wrap functions inline too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #603.