Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cirq: 0.6.1 -> 0.8.0 #87635

Merged
merged 1 commit into from May 14, 2020
Merged

python3Packages.cirq: 0.6.1 -> 0.8.0 #87635

merged 1 commit into from May 14, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Update python3Packages.cirq to latest version.

See release notes: https://github.com/quantumlib/Cirq/releases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger drewrisinger marked this pull request as ready for review May 14, 2020 21:50
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.cirq python38Packages.cirq

jonringer
jonringer approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 87635 1

2 packages built: - python37Packages.cirq - python38Packages.cirq

@jonringer jonringer merged commit ec7dbdb into NixOS:master May 14, 2020
@drewrisinger drewrisinger deleted the dr-pr-py-cirq-bump branch May 15, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @jonringer