[20.03] nixos/test-driver: Specify /bin/sh shell when running a bourne shell script as the user #87618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…script as the user (cherry picked from commit 751a270) Reason: Back-porting this straight-forward fix is the best way to allow tests affected by this user-shell problem to run in 20.03. There isn't a great override point to apply just this fix. Copy/pasting testing-python.nix just to specify a new test-driver.py isn't great -- it would cut off receiving any other fixes in the testing infrastructure until 20.09. A 20.03 system using testing-python.nix from the unstable branch and then passing 20.03's pkgs in to avoid getting unstable's pkgs is quite a bit of configuration to expect from clients and seems fragile against future changes in the unstable branch that expect pkgs to be mostly in-sync with the test driver. Both of these not-great options leave a bunch of "TODO: Remove after 20.09" junk in clients' configs & make that upgrade harder.
prusnak
added
the
8.has: port to stable
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
@GrahamcOfBorg test grafana |
|
based upon discussion on master PR, I think this is good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport #87414 , which allows tests to run when a user has changed their login shell.
(cherry picked from commit 751a270)
Reason: Back-porting this straight-forward fix is the best way to
allow tests affected by this user-shell problem to run in 20.03.
There isn't a great override point to apply just this fix. Copy/pasting
testing-python.nix just to specify a new test-driver.py isn't great --
it would cut off receiving any other fixes in the testing infrastructure
until 20.09. A 20.03 system using testing-python.nix from the unstable
branch and then passing 20.03's pkgs in to avoid getting unstable's
pkgs is quite a bit of configuration to expect from clients and seems
fragile against future changes in the unstable branch that expect pkgs
to be mostly in-sync with the test driver. Both of these not-great
options leave a bunch of "TODO: Remove after 20.09" junk in clients'
configs & make that upgrade harder.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)